OBPIH-6345 Show translated names on PO edit page and modal (fixes after QA)#4621
Merged
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from May 15, 2024
Merged
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
kchelstowski
requested changes
May 15, 2024
| attrs.from = order.listOrderItems() | ||
| attrs.optionKey = 'id' | ||
| attrs.optionValue = { it.toString() } | ||
| attrs.optionValue = { it.productDisplayName } |
Collaborator
There was a problem hiding this comment.
can't you just do it.product?.displayNameOrDefaultName?
| String getProductDisplayName() { | ||
| return product?.displayName ?: product?.name | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
even if this method turns out to be necessary, which I doubt, this could still be shortened to:
String getProductDisplayName() {
return product?.displayNameOrDefaultName
}
kchelstowski
approved these changes
May 15, 2024
awalkowiak
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.