OBPIH-6356 Fixed bug causing fatal exception if sentry.dsn is not pro…#4620
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from May 17, 2024
Merged
Conversation
…vided; added default sentry.properties file to classpath; removed old sentry plugin config;
jmiranda
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
ewaterman
reviewed
May 15, 2024
| @@ -0,0 +1 @@ | |||
| dsn= | |||
Member
There was a problem hiding this comment.
does this work? (meaning does it successfully disable sentry?)
Member
Author
There was a problem hiding this comment.
Yes, it's the only thing that does.
Member
Author
There was a problem hiding this comment.
I was planning to move all of the default config from SentryServletContainerInitializer to this file, but given how much of a pain in the neck this was I didn't want to do more than what was required. So I'll add a ticket to handle that and figuring out a way to get the SentryServletContainerInitializer to work in all environments or replace it with custom init method in BootStrap.groovy.
ewaterman
approved these changes
May 15, 2024
awalkowiak
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…vided; added default sentry.properties file to classpath; removed old sentry plugin config;