OBPIH-6327 Data model should support "to pick" and "picked" stages#4607
OBPIH-6327 Data model should support "to pick" and "picked" stages#4607awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman,
jmiranda and
kchelstowski
| addForeignKeyConstraint( | ||
| baseColumnNames: "picker_id", | ||
| baseTableName: "picklist_item", | ||
| constraintName: "fk_picker_person", |
There was a problem hiding this comment.
One thing that caught my eye before merging it. Could you change the name of this constraint to match a convention of having names of base table name and referenced table name -> fk_picklist_item_person
There was a problem hiding this comment.
Actually, your version makes more sense, let me think shortly about this one
There was a problem hiding this comment.
Yeah I was partially right. We usually do fk + base table name + base column name (without _id) for these constraint names, so I think this could be the way for this one, but your version fk + base column name + reference table name is ok too I guess
There was a problem hiding this comment.
As discussed internally on slack we are going to use a convention of fk_baseTable_baseColumn_referenceTable if the changelogs are not generated.
jmiranda
left a comment
jmiranda
left a comment
There was a problem hiding this comment.
Sorry, just got to this now. LGTM.
jmiranda
left a comment
jmiranda
left a comment
There was a problem hiding this comment.
... although I'm starting to second guess myself on the naming of the picker property. Should have probably been pickedBy to stay consistent with other fields.
4 participants
No description provided.