OBPIH-5978 Improve the date shipped field to show a user who shipped the SM, not the one, who created it.#4599
Merged
awalkowiak merged 3 commits intofeature/upgrade-to-grails-3.3.10from Apr 26, 2024
Conversation
…the SM, not the one, that created it.
kchelstowski
requested review from
alannadolny,
awalkowiak,
drodzewicz and
ewaterman
ewaterman
reviewed
Apr 25, 2024
ewaterman
approved these changes
Apr 25, 2024
awalkowiak
reviewed
Apr 25, 2024
grails-app/views/returns/show.gsp
Outdated
| <g:formatDate format="MMMM dd, yyyy" date="${stockMovement?.dateShipped}"/> | ||
| </span> | ||
| <g:if test="${stockMovement?.shipment?.createdBy}"> | ||
| <g:if test="${stockMovement?.shipment?.shippedBy || stockMovement?.shipment?.createdBy}"> |
Collaborator
There was a problem hiding this comment.
Can you move this fallback to created by to the shipment's shippedBy method? It could be something like if there is no shipped event and there is a case we want to return created by, then it would be returned.
Collaborator
Author
There was a problem hiding this comment.
@awalkowiak I guess it should be if there IS shipped event, because otherwise we don't want to display any user (until the SM is shipped).
I'm gonna push the change and let me know if we are on the same page
awalkowiak
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.