OBPIH-6300 In progress status for fulfillment steps on requestor's dashboard#4583
Merged
awalkowiak merged 4 commits intofeature/upgrade-to-grails-3.3.10from Apr 16, 2024
Merged
OBPIH-6300 In progress status for fulfillment steps on requestor's dashboard#4583awalkowiak merged 4 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 4 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
awalkowiak
reviewed
Apr 15, 2024
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
Is this getDisplayStatus() only used on the requestor's dashboard?
I feel like this ticket is a really good candidate to write some unit tests around it.
| REJECTED(10, REJECTED), | ||
|
|
||
| // Status on the requestor's dashboard representing verifying, checked, picking and picked | ||
| IN_PROGRESS(3, PENDING), |
Collaborator
There was a problem hiding this comment.
I wonder if this should not be the display status on its own (below the PENDING), without sort order, and should not take PENDING as its own displayStatusCode 🤔
Collaborator
Author
There was a problem hiding this comment.
Is this getDisplayStatus() only used on the requestor's dashboard?
yes, it was introduced for mapping approval statuses for the requestor's dashboard
awalkowiak
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.