OBPIH-6288 Do not allow to re-generate source code when importing pro…#4573
Merged
awalkowiak merged 2 commits intorelease/0.9.1from Apr 2, 2024
Merged
OBPIH-6288 Do not allow to re-generate source code when importing pro…#4573awalkowiak merged 2 commits intorelease/0.9.1from
awalkowiak merged 2 commits intorelease/0.9.1from
Conversation
…duct sources and the code is not provided
alannadolny
approved these changes
Mar 29, 2024
| String sourceCode = productSupplier.code | ||
| productSupplier.properties = params | ||
| // Do not allow to bind an empty source code, which caused the code to be re-generated for an existing product supplier (OBPIH-6288) | ||
| // The code could be overwritten by the binding in the 212th line, hence we'd like to bring back the existing code, if the one in params is null/empty |
Collaborator
There was a problem hiding this comment.
in the 212th line
If someone changes the code above, it won't be 212th line 😄
Collaborator
There was a problem hiding this comment.
Yeah let's avoid doing that, I know I did it once or twice in the past, but let's refrain from adhering to line numbers in comments.
awalkowiak
requested changes
Mar 29, 2024
| String sourceCode = productSupplier.code | ||
| productSupplier.properties = params | ||
| // Do not allow to bind an empty source code, which caused the code to be re-generated for an existing product supplier (OBPIH-6288) | ||
| // The code could be overwritten by the binding in the 212th line, hence we'd like to bring back the existing code, if the one in params is null/empty |
Collaborator
There was a problem hiding this comment.
Yeah let's avoid doing that, I know I did it once or twice in the past, but let's refrain from adhering to line numbers in comments.
awalkowiak
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…duct sources and the code is not provided