OBPIH-6268 Change "Average Unit Price" to "Unit Price" with "Last Paid" tooltip in all places#4563
Merged
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from Mar 25, 2024
Merged
Conversation
awalkowiak
reviewed
Mar 25, 2024
| enum.RequisitionStatus.PENDING=Pending | ||
| enum.RequisitionStatus.PICKED=Picked | ||
| enum.RequisitionStatus.PICKING=Picking | ||
| enum.RequisitionStatus.APPROVED=Approved |
Collaborator
There was a problem hiding this comment.
Why you removed these?
Collaborator
There was a problem hiding this comment.
NVM, I just read your comment.
kchelstowski
approved these changes
Mar 25, 2024
| <th><g:message code="product.pricePerUnit.label" default="Unit Price" /></th> | ||
| <th title="${g.message(code: "product.lastPaid.label", default: "Last Paid")}"> | ||
| <g:message code="product.unitPrice.label" default="Unit Price" /> | ||
| </th> |
Collaborator
There was a problem hiding this comment.
probably doesn't make sense, since there are not many of these, but was wondering about a custom tag for that.
anyway, lgtm
awalkowiak
requested changes
Mar 25, 2024
grails-app/views/inventory/list.gsp
Outdated
| <th class="center border-right"><warehouse:message code="default.quantityAvailableToPromise.label" default="Quantity ATP"/></th> | ||
| <th><warehouse:message code="product.pricePerUnit.label" default="Price per unit"/></th> | ||
| <th title="${g.message(code: "product.lastPaid.label", default: "Last Paid")}"> | ||
| <warehouse:message code="product.unitPrice.label" default="Unit Price"/> |
Collaborator
There was a problem hiding this comment.
I think we want to go with g:message
awalkowiak
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from the changes that were requested in the ticket, I removed 3 duplicated keys, that were created while implementing approvals.