OBPIH-6086 update actual ready date on multiple POs via import#4556
Merged
awalkowiak merged 8 commits intofeature/upgrade-to-grails-3.3.10from Mar 20, 2024
Conversation
…ode is sam as on given order item
- make orderItem not required - lookup orderItem by provided order and product
alannadolny
approved these changes
Mar 20, 2024
|
|
||
| // Product validation | ||
| if (!params["productCode"]) { | ||
| command.errors.reject("Row ${index + 1}: 'productCode' is required") |
Collaborator
There was a problem hiding this comment.
I am wondering whether those errors should be translatable. Do you think there's a need for that? Or we can leave it as is? 🤔
| "orderNumber" : ([expectedType: ExpectedPropertyType.StringType, defaultValue: null]), | ||
| "productCode" : ([expectedType: ExpectedPropertyType.StringType, defaultValue: null]), | ||
| "productName" : ([expectedType: ExpectedPropertyType.StringType, defaultValue: null]), | ||
| "actualReadyDate" : ([expectedType: ExpectedPropertyType.StringType, defaultValue: null]), |
Collaborator
There was a problem hiding this comment.
I am assuming it should be StringType instead of Date?
awalkowiak
approved these changes
Mar 20, 2024
awalkowiak
deleted the
OBPIH-6086-update-actual-ready-date-on-multiple-p-os-via-import
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.