OBPIH-6126 Rename supplier product name and site name to other generic names#4543
Merged
awalkowiak merged 4 commits intofeature/upgrade-to-grails-3.3.10from Mar 14, 2024
Merged
OBPIH-6126 Rename supplier product name and site name to other generic names#4543awalkowiak merged 4 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 4 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
awalkowiak
reviewed
Mar 14, 2024
| react.productSupplier.column.supplier.label=Supplier | ||
| react.productSupplier.column.supplierCode.label=Supplier Code | ||
| react.productSupplier.column.supplierProductName.label=Supplier Product Name | ||
| react.productSupplier.column.name.label=(Source) Name |
Collaborator
There was a problem hiding this comment.
Why (Source) is in parenthesis? Was that requested?
Collaborator
Author
There was a problem hiding this comment.
The ticket describes these changes as follows
The generic name for “Supplier Product Name” should be “(Source) Name” - the custom translation for PIH will be “Supplier Product Name”
since the whole word (new name) is in quotes I assume this is the new expected name
awalkowiak
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was requested to change the generic name for fields/columns Supplier Product Name and Site Name to (Source) Name and Organization
Additionally I have added jsdoc to our translation hook and utils function to describe what each parameter is doing because I find it confusing every time I want to remember which parameter takes in data defaultMessage etc...