OBPIH-6108 Trigger validation on default preference type clearing (Fixes after QA)#4540
Merged
kchelstowski merged 3 commits intofeature/product-supplier-list-redesignfrom Mar 11, 2024
Conversation
… preference type subsection
- prevent inputs from jumping when errors appear under the input
| .optional(), | ||
| bidName: z | ||
| .string() | ||
| .nullable() |
Collaborator
There was a problem hiding this comment.
this can be either changed to .nullish() or removed at all, because you made a fallback for ?? undefined
kchelstowski
approved these changes
Mar 11, 2024
alannadolny
approved these changes
Mar 11, 2024
kchelstowski
deleted the
OBPIH-6108-add-preference-type-section-with-inputs
branch
awalkowiak
pushed a commit
that referenced
this pull request
Mar 12, 2024
…xes after QA) (#4540) * OBPIH-6108 trigger validation on PreferenceType when clearing default preference type subsection * OBPIH-6108 Fix input error message styling on a form - prevent inputs from jumping when errors appear under the input * OBPIH-6108 chnage optional and null to nullish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undefinedinstead ofnullon validityStartDate, validityEndDate and bidName because API returnsnulland Zod parsesnullto some date value when usingcoerce.date()minHeighton error message to prevent this height change when error appears)