OBPIH-6232 hyperlink to source edit and stockcard on sources list page#4532
Merged
awalkowiak merged 3 commits intofeature/product-supplier-list-redesignfrom Mar 6, 2024
Conversation
alannadolny
approved these changes
Mar 5, 2024
kchelstowski
reviewed
Mar 5, 2024
| showStockCard: (id, params = {}) => stringifyUrl({ | ||
| url: `${INVENTORY_ITEM_URL.base}/showStockCard/${id}`, | ||
| query: { activeTab: params?.activeTab }, | ||
| }), |
Collaborator
There was a problem hiding this comment.
if we allow params to be passed, shouldn't we do the spread inside query to handle other params that might be included somewhere and if we forgot to include them explicitly inside the query
query: { ...params, activeTab: params?.activeTab },
drodzewicz
force-pushed
the
OBPIH-6232-hyperlink-to-source-edit-and-stockcard-on-sources-list-page
branch
from
6732161 to
124a222
Compare
kchelstowski
approved these changes
Mar 5, 2024
awalkowiak
approved these changes
Mar 6, 2024
awalkowiak
deleted the
OBPIH-6232-hyperlink-to-source-edit-and-stockcard-on-sources-list-page
branch
awalkowiak
pushed a commit
that referenced
this pull request
Mar 12, 2024
#4532) * OBPIH-6232 Added hyperlink to source edit page on product source code * OBPIH-6232 open product stockcard in a new tab * OBPIH-6232 open stock card page with specified tab open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.