OBPIH-6111 Fix substitution and calculation of each price#4529
Merged
awalkowiak merged 1 commit intofeature/product-supplier-list-redesignfrom Mar 4, 2024
Merged
OBPIH-6111 Fix substitution and calculation of each price#4529awalkowiak merged 1 commit intofeature/product-supplier-list-redesignfrom
awalkowiak merged 1 commit intofeature/product-supplier-list-redesignfrom
Conversation
awalkowiak
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug has been introduced by this commit: ad70248
When editing a source, the product package quantity was cleared (set to
undefined) after initialization of default values of the product source.It was due to two
useEffectsimpacting on each other - at first we were setting the default values ingetDefaultValuesmethod, and since theuomwas also set, it triggered theuseEffectthat was eventually setting the product package quantity toundefined.This
useEffectwould be OK, but if it was triggered only for manual editing of theuom- since we can't distiungish whether it has been run manually or by theuomchange of thegetDefaultValues, I refactored this to be a method that is triggeredonChangeof theuominput.