OBPIH-6111 add pricing section with inputs#4524
Merged
awalkowiak merged 8 commits intofeature/product-supplier-list-redesignfrom Mar 1, 2024
Merged
Conversation
…ty to 1 and disable the field
drodzewicz
force-pushed
the
OBPIH-6111-add-pricing-section-with-inputs
branch
from
2395e04 to
e1997c9
Compare
|
|
||
| // preselect value 1 when unit of measure Each is selected | ||
| useEffect(() => { | ||
| if (uom?.id === 'EA') { |
Collaborator
There was a problem hiding this comment.
this feels dangerous to me. Are we sure that on every instance this would have the id of 'EA'?
I think we'd be safer if we looked at uom.code, but we would have to include the code in the response of uoms and change the getDefaultValues() to include the code.
Unless @awalkowiak / @jmiranda know if this will always have id of 'EA' on any instance, then we can let it go.
Collaborator
There was a problem hiding this comment.
I can see that we insert the "EA" unit of measure in one of the migrations:
<insert tableName="unit_of_measure">
<column name="id" value="EA"/>
<column name="version" valueNumeric="0"/>
<column name="code" value="EA"/>
<column name="name" value="Each"/>
<column name="uom_class_id" value="QUANTITY"/>
<column name="created_by_id" value="1"/>
<column name="updated_by_id" value="1"/>
<column name="date_created" valueDate="2020-04-25T00:00:00.0"/>
<column name="last_updated" valueDate="2020-04-25T00:00:00.0"/>
</insert>so I think we are fine with checking the uom.id at this point
kchelstowski
approved these changes
Feb 29, 2024
|
|
||
| // preselect value 1 when unit of measure Each is selected | ||
| useEffect(() => { | ||
| if (uom?.id === 'EA') { |
Collaborator
There was a problem hiding this comment.
I can see that we insert the "EA" unit of measure in one of the migrations:
<insert tableName="unit_of_measure">
<column name="id" value="EA"/>
<column name="version" valueNumeric="0"/>
<column name="code" value="EA"/>
<column name="name" value="Each"/>
<column name="uom_class_id" value="QUANTITY"/>
<column name="created_by_id" value="1"/>
<column name="updated_by_id" value="1"/>
<column name="date_created" valueDate="2020-04-25T00:00:00.0"/>
<column name="last_updated" valueDate="2020-04-25T00:00:00.0"/>
</insert>so I think we are fine with checking the uom.id at this point
awalkowiak
pushed a commit
that referenced
this pull request
Mar 12, 2024
* OBPIH-6111 Fixed issue where form is unsavable when package price is not filled in * OBPIH-6111 Fix issue with preceeding zeros in input type number * OBPIH-6111 Fix null contractPrice in api response * OBPIH-6111 Prevent from entering fractions on package quantity * OBPIH-6111 When unit of measure Each is selected, set value of quantity to 1 and disable the field * OBPIH-6111 use grid system provided by bootstrap to align form inputs * OBPIH-6111 Removed possibility for minimum Order quantity to enter fractions * OBPIH-6111 Added same padding values as on other form sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing you may notice are changes to some other sections. This is because I have added the bootstrap grid system as a wrapper for our fields.
One of the reopen change requests I got was that my fields we not in the same layout as on the mock so I decided to use bootstrap grid system to solve this issue.
To not have different approaches in other sections I did the following modifications and also added
rowandcol-lgclasses