OBPIH-6118 Improve preference type and add rating type option endpoints#4518
Merged
kchelstowski merged 7 commits intofeature/product-supplier-list-redesignfrom Feb 23, 2024
Merged
Conversation
drodzewicz
requested changes
Feb 23, 2024
grails-app/controllers/org/pih/warehouse/api/SelectOptionsApiController.groovy
Outdated
Show resolved
Hide resolved
grails-app/controllers/org/pih/warehouse/api/SelectOptionsApiController.groovy
Outdated
Show resolved
Hide resolved
alannadolny
requested changes
Feb 23, 2024
| } | ||
|
|
||
| def ratingTypeCodeOptions() { | ||
| List ratingTypeCodeOptions = RatingTypeCode.list().collect { |
Collaborator
There was a problem hiding this comment.
Make this List type parametrized
kchelstowski
requested changes
Feb 23, 2024
grails-app/controllers/org/pih/warehouse/api/SelectOptionsApiController.groovy
Outdated
Show resolved
Hide resolved
alannadolny
requested changes
Feb 23, 2024
kchelstowski
approved these changes
Feb 23, 2024
alannadolny
approved these changes
Feb 23, 2024
drodzewicz
approved these changes
Feb 23, 2024
jmiranda
changed the title
awalkowiak
added a commit
that referenced
this pull request
Mar 12, 2024
…dpoints (#4518) * OBPIH-6118 Improve preference type options endpoint * OBPIH-6115 Create rating type options endpoint * OBPIH-6118 Fixes after review * OBPIH-6115 Replace mocked rating type options and use new endpoint * OBPIH-6115 Use api service in actions * OBPIH-6115 Add abort controller * OBPIH-6115 Add missing signal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.