OBPIH-6116 Refactor uom options endpoint to be able to receive type p…#4516
Merged
awalkowiak merged 2 commits intofeature/product-supplier-list-redesignfrom Feb 22, 2024
Merged
Conversation
…aram, which filters by uom class
drodzewicz
approved these changes
Feb 22, 2024
alannadolny
approved these changes
Feb 22, 2024
awalkowiak
requested changes
Feb 22, 2024
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
Assuming you can now pass UnitOfMeasureType in the parameters, then the second currency endpoint you added is not required anymore. Please remove it (but leave the "deprecated" one)
awalkowiak
requested changes
Feb 22, 2024
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
You need to also include a change on the front end
kchelstowski
force-pushed
the
OBPIH-6116-fix
branch
from
7d2df3e to
6706229
Compare
awalkowiak
approved these changes
Feb 22, 2024
awalkowiak
pushed a commit
that referenced
this pull request
Mar 12, 2024
#4516) * OBPIH-6116 Refactor uom options endpoint to be able to receive type param, which filters by uom class * OBPIH-6116 Remove plural url mapping for currencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…aram, which filters by uom class
I decided not to get rid of the currencies endpoint in case somebody uses this API.