OBPIH-6109 Implement preference type variations subsection with the table#4510
Merged
awalkowiak merged 16 commits intofeature/product-supplier-list-redesignfrom Feb 22, 2024
Merged
OBPIH-6109 Implement preference type variations subsection with the table#4510awalkowiak merged 16 commits intofeature/product-supplier-list-redesignfrom
awalkowiak merged 16 commits intofeature/product-supplier-list-redesignfrom
Conversation
awalkowiak
requested changes
Feb 20, 2024
src/js/components/productSupplier/create/subsections/PreferenceTypeVariations.jsx
Show resolved
Hide resolved
src/js/components/productSupplier/create/subsections/PreferenceTypeVariations.jsx
Show resolved
Hide resolved
kchelstowski
requested changes
Feb 20, 2024
| import usePreferenceTypeVariationsColumns | ||
| from 'hooks/productSupplier/form/usePreferenceTypeVariationsColumns'; | ||
|
|
||
| const PreferenceTypeVariations = ({ control, errors: { productSupplierPreferences } }) => { |
Collaborator
There was a problem hiding this comment.
I don't like the naming (productSuppllierPreferences). Let's stick to errors or at least pass it to the hook like:
usePreferenceTypeVariationsColumns({
errors: productSupplierPreferences,
control,
remove,
});and use it in the hook via errors.
Collaborator
There was a problem hiding this comment.
I get, why you wanted to do it like this, but I think it's not a big of a deal to receive all errors here, or you could just pass productSupplierPreferences' errors when invoking the component:
<PreferenceTypeSection
control={control}
errors={errors.productSupplierPreferences}
/>| preferenceType: {}, | ||
| validityStartDate: '', | ||
| validityEndDate: '', | ||
| bidName: '', |
Collaborator
There was a problem hiding this comment.
let's maybe store those in a const to a better readability?
| })} | ||
| StartIcon={<RiAddLine className="button-add-icon" />} | ||
| defaultLabel="Add new" | ||
| label="Add new" |
Collaborator
There was a problem hiding this comment.
shouldn't it be a translation key?
src/js/components/productSupplier/create/subsections/PreferenceTypeVariations.jsx
Show resolved
Hide resolved
| /> | ||
| ), | ||
| }, | ||
| ], [productSupplierPreferences]); |
Collaborator
There was a problem hiding this comment.
buyers and preferenceTypes should also be in the dependency array (and errors potentially too)
| invalid_type_error: 'Preference type is required', | ||
| required_error: 'Preference type is required', | ||
| }).required(), | ||
| validityEndDate: z.string().optional().nullable(), |
Collaborator
There was a problem hiding this comment.
let's maybe also chain it, as I've started with such convention for properties above?
kchelstowski
requested changes
Feb 21, 2024
| remove, | ||
| }); | ||
|
|
||
| const defualtTableRow = { |
| validityEndDate: '', | ||
| bidName: '', | ||
| })} | ||
| onClick={() => append(defualtTableRow)} |
| ), | ||
| }, | ||
| ], [productSupplierPreferences]); | ||
| ], [errors]); |
Collaborator
There was a problem hiding this comment.
include the dependencies I've mentioned in the previous comment
alannadolny
force-pushed
the
OBPIH-6109
branch
from
f8cb311 to
778c1be
Compare
alannadolny
force-pushed
the
OBPIH-6109
branch
from
778c1be to
c0fe27c
Compare
kchelstowski
approved these changes
Feb 22, 2024
awalkowiak
approved these changes
Feb 22, 2024
awalkowiak
pushed a commit
that referenced
this pull request
Mar 12, 2024
…able (#4510) * OBPIH-6109 Create section and subsection for preference type variations * OBPIH-6109 Adjust form and validation hook * OBPIH-6109 Create util for differentiate default preference types from others * OBPIH-6109 Use section and subsection in new form * OBPIH-6109 Create invalid items indicator * OBPIH-6109 Create hooks for preference type variations columns * OBPIH-6109 Add styling * OBPIH-6109 Fix datepicker format * OBPIH-6109 Add translations * OBPIH-6109 Fix styling of v2 input components * OBPIH-6109 Fix fontSize of react select icons * OBPIH-6109 Fix placement of datefield component in subsections * OBPIH-6109 Sort imports * OBPIH-6109 Fixes after review * OBPIH-6109 Fixes after review * OBPIH-6109 Fixes after rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.