OBPIH-6042 Add filter by date range to expiration reports (fix after QA)#4497
Merged
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from Feb 8, 2024
Merged
OBPIH-6042 Add filter by date range to expiration reports (fix after QA)#4497awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
awalkowiak
reviewed
Feb 8, 2024
|
|
||
| if (command.startDate) { | ||
| ge("expirationDate", command.startDate) | ||
| gt("expirationDate", command.startDate + 1) |
Collaborator
There was a problem hiding this comment.
@alannadolny Does this require both changes? ge -> gt and adding + 1?
Collaborator
Author
There was a problem hiding this comment.
Yup, when I just changed ge -> gt I got the same results, It's probably due to hours comparison, but now it works fine.
Collaborator
There was a problem hiding this comment.
@alannadolny Then I think you have to still have ge if you add + 1, because you are missing records that are from the startDate + 1, but don't have hours added
awalkowiak
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.