OBPIH-6123 Review eslint changes made on OBGM and adjust them#4493
Merged
awalkowiak merged 1 commit intofeature/product-supplier-list-redesignfrom Feb 8, 2024
Merged
OBPIH-6123 Review eslint changes made on OBGM and adjust them#4493awalkowiak merged 1 commit intofeature/product-supplier-list-redesignfrom
awalkowiak merged 1 commit intofeature/product-supplier-list-redesignfrom
Conversation
kchelstowski
changed the title
drodzewicz
approved these changes
Feb 7, 2024
alannadolny
approved these changes
Feb 7, 2024
awalkowiak
reviewed
Feb 7, 2024
| "arrow-parens": "warn", | ||
| "implicit-arrow-linebreak": "warn", | ||
| "arrow-parens": "error", | ||
| "implicit-arrow-linebreak": "off", |
Collaborator
There was a problem hiding this comment.
I think this only one that I am not sure about, personally I'd prefer it to be ["error", "beside"], but we can discuss it on slack or in the ticket.
Collaborator
|
I am merging this as is now, but will think about the arrow linebreak while adding GHA for running unit tests and frontend linter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.