OBPIH-5905 New submenus in Inventory menu#4481
Merged
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from Jan 29, 2024
Merged
OBPIH-5905 New submenus in Inventory menu#4481awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
awalkowiak
requested changes
Jan 29, 2024
grails-app/conf/runtime.groovy
Outdated
| menuItems = [ | ||
| // TODO: Add option to include label 'beta' | ||
| [label: "inventory.browse.label", defaultLabel: "Browse Inventory", href: "/inventoryBrowser/index"], | ||
| [label: "inventory.view.label", defaultLabel: "Inventory Browser", href: "/inventoryBrowser/index"], |
Collaborator
There was a problem hiding this comment.
inventory.view.label is View Inventorym your default is Inventory Browser, which one you are expecting here? If the later one, then add a separate message property, if the former one, then change the default label
| inventory.backToStockCard.label=Back to stock card | ||
| inventory.belowMinimumLevel.label=Below minimum level | ||
| inventory.belowReorderLevel.label=Below reorder level | ||
| inventory.browse.label=Browse inventory |
Collaborator
There was a problem hiding this comment.
Is this one no longer used?
awalkowiak
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I included here the simple change with quotes mentioned in this ticket: https://pihemr.atlassian.net/browse/OBPIH-6067?atlOrigin=eyJpIjoiYmU0MTAxY2JjNGRiNDY2MThkMTQ0ZmM1ZmQ2NjU0MzkiLCJwIjoiaiJ9