OBPIH-6020 Preference Type Modal#4480
Merged
awalkowiak merged 3 commits intofeature/product-supplier-list-redesignfrom Jan 31, 2024
Merged
OBPIH-6020 Preference Type Modal#4480awalkowiak merged 3 commits intofeature/product-supplier-list-redesignfrom
awalkowiak merged 3 commits intofeature/product-supplier-list-redesignfrom
Conversation
awalkowiak
requested changes
Jan 29, 2024
Comment on lines
66
to
78
| roles: [RoleType.ROLE_PRODUCT_MANAGER], | ||
| minimumRequiredRole: isAdmin, |
Collaborator
There was a problem hiding this comment.
Do these need to be separated? Could ROLE_ADMIN be moved to the roles, and then just checked if all required roles are there?
Collaborator
Author
There was a problem hiding this comment.
@awalkowiak I think it's better to have it separated because it's a minimum required role, so when I pass the admin role, I can also be a superuser, and it still should be true. When I have to check the admin role within the roles argument I have to include the superuser here.
Collaborator
There was a problem hiding this comment.
@alannadolny Ok, but then call it supplementalRoles as it is on the backend, and maybe change the ordering of these params. So we have "required roles" first, and then "supplemental" ones.
Collaborator
|
@alannadolny plus fix the conflicts |
alannadolny
force-pushed
the
OBPIH-6020-3
branch
from
10c162e to
eb31e29
Compare
awalkowiak
approved these changes
Jan 31, 2024
awalkowiak
pushed a commit
that referenced
this pull request
Mar 12, 2024
* OBPIH-6020 Change font size to smaller * OBPIH-6020 Fixes after product source review * OBPIH-6020 Change naming of the argument in hasPermission function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I included fixes after @awalkowiak's review in the product source feature branch in this PR