OBPIH-5067 Sort items on Vendor filter on invoice list alphabetically #4475
Merged
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from Jan 26, 2024
Merged
OBPIH-5067 Sort items on Vendor filter on invoice list alphabetically #4475awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
| } | ||
| if (params.sort && params.order) { | ||
| order(params.sort, params.order) | ||
| } |
Collaborator
There was a problem hiding this comment.
this would probably crash if a user provided a non-existing sort param, e.g. &sort=test. (Remember this endpoint is achievable also from API, not only from the UI).
I don't know if we wanna prevent that from happening and assume that no one would do so, but we used to do it like:
if (params.sort == "name") {
order("name", params.order ?: "asc")
}
alannadolny
force-pushed
the
OBPIH-5067
branch
from
a1ef6e4 to
bfe35f3
Compare
kchelstowski
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.