OBPIH-6035 New triangle icons for adjustments in stock history#4469
Merged
awalkowiak merged 3 commits intofeature/upgrade-to-grails-3.3.10from Jan 26, 2024
Merged
OBPIH-6035 New triangle icons for adjustments in stock history#4469awalkowiak merged 3 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 3 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
kchelstowski
approved these changes
Jan 23, 2024
awalkowiak
requested changes
Jan 23, 2024
| } | ||
|
|
||
| Boolean isAdjustment() { | ||
| compareName("Adjustment") |
Collaborator
There was a problem hiding this comment.
Let's move "Adjustment" to the const, and please add a comment here why it's determined like that.
drodzewicz
approved these changes
Jan 24, 2024
awalkowiak
reviewed
Jan 25, 2024
| return name.split(regex)[0] == transactionTypeName.split(regex)[0] | ||
| } | ||
|
|
||
| // Checking whether the transaction type is adjustment for displaying the appropriate icon on the stock history page |
Collaborator
There was a problem hiding this comment.
@alannadolny I meant rather to put a comment here "why it's determined by doing compareName(Constants.ADJUSTMENT)", not "for what it is used"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.