OBPIH-5967 Can edit completed putaway when go back to edit page after complete#4459
Conversation
drodzewicz
requested review from
alannadolny,
awalkowiak,
jmiranda and
kchelstowski
| putawayItem.inventoryLevel = InventoryLevel.findByProductAndInventory(putawayItem.product, putaway.origin.inventory) | ||
| putawayItem.quantityAvailable = productAvailabilityService.getQuantityOnHandInBinLocation(putawayItem.inventoryItem, putawayItem.currentLocation) | ||
| } | ||
| response.setHeader("Cache-Control", "no-store") |
There was a problem hiding this comment.
It is to prevent the browser from caching this response.
Follow the comment I posted in the ticket
There was a problem hiding this comment.
You cced Artur twice 😄
Now, I got it, thanks
There was a problem hiding this comment.
I am still baffled by the need for this
There was a problem hiding this comment.
I feel like it is something that we need to discuss and decide.
I wanted to show the issue and a potential solution.
If we feel like disabling the cache in the header is not the way to go, just a single validation should be enough to prevent users from messing with completed putaways based on old data.
There was a problem hiding this comment.
Yeah, I feel like, having the validation should be enough. However, you can showcase or explain the cache store tomorrow morning
drodzewicz
force-pushed
the
OBPIH-5967-can-edit-completed-putaway-when-go-back-to-edit-page-after-complete
branch
from
2fbf58a to
a6aa042
Compare
awalkowiak
deleted the
OBPIH-5967-can-edit-completed-putaway-when-go-back-to-edit-page-after-complete
branch
3 participants
Follow the discussion in the ticket