OBPIH-6018 Add product sources list table#4436
Merged
kchelstowski merged 9 commits intofeature/product-supplier-list-redesignfrom Dec 29, 2023
Merged
OBPIH-6018 Add product sources list table#4436kchelstowski merged 9 commits intofeature/product-supplier-list-redesignfrom
kchelstowski merged 9 commits intofeature/product-supplier-list-redesignfrom
Conversation
kchelstowski
requested review from
alannadolny,
awalkowiak,
drodzewicz and
jmiranda
alannadolny
reviewed
Jan 3, 2024
Comment on lines
+4269
to
+4280
| react.productSupplier.column.productCode.label=Product Code | ||
| react.productSupplier.column.productName.label=Product Name | ||
| react.productSupplier.column.sourceCode.label=Source Code | ||
| react.productSupplier.column.preferenceType.label=Preference Type | ||
| react.productSupplier.column.defaultPackSize.label=Default Pack Size | ||
| react.productSupplier.column.packagePrice.label=Package Price | ||
| react.productSupplier.column.eachPrice.label=Each Price | ||
| react.productSupplier.column.supplier.label=Supplier | ||
| react.productSupplier.column.supplierCode.label=Supplier Code | ||
| react.productSupplier.column.supplierProductName.label=Supplier Product Name | ||
| react.productSupplier.column.dateCreated.label=Date Created | ||
| react.productSupplier.column.status.label=Status |
Collaborator
There was a problem hiding this comment.
I think the column part is not needed.
react.productSupplier.productCode.label=Product Code
react.productSupplier.productName.label=Product Name
react.productSupplier.sourceCode.label=Source Code
react.productSupplier.preferenceType.label=Preference Type
react.productSupplier.defaultPackSize.label=Default Pack Size
react.productSupplier.label=Package Price
react.productSupplier.eachPrice.label=Each Price
react.productSupplier.supplier.label=Supplier
react.productSupplier.supplierCode.label=Supplier Code
react.productSupplier.supplierProductName.label=Supplier Product Name
react.productSupplier.dateCreated.label=Date Created
react.productSupplier.status.label=Status
To be honest, I am not sure about the productSupplier also. Most of those translations can be potentially used in a lot of future redesigns, so I am thinking about having those under something similar like react.default.
Collaborator
Author
There was a problem hiding this comment.
For all list pages we used to distinguish what's used for the columns, what's used for the table etc.
We once decided that "the same" labels could have different context in some places - this is why we also don't use the react.default for most of them.
I don't remember where, but probably even for some of the new list pages we've had a discussion about that.
awalkowiak
pushed a commit
that referenced
this pull request
Mar 12, 2024
* OBPIH-6018 Add package price property to product supplier toJson * OBPIH-6018 Add translations for labels for the product sources table * OBPIH-6018 Add an api url for product sources on the react side * OBPIH-6018 Include new packagePrice property in ProductSupplierListDto * OBPIH-6018 Add components for product source table * OBPIH-6018 Remove unused imports + fix eslint in ProductSupplierTabs component * OBPIH-6018 Add hook for logic of fetching product sources data * OBPIH-6018 Add generic wrappers for list table * OBPIH-6018 Fix label for no data text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.