OBGM-577 Change product supplier identifier format to be the same as on develop branch#4174
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jul 17, 2023
Conversation
…on develop branch
awalkowiak
approved these changes
Jul 17, 2023
awalkowiak
deleted the
OBGM-577-automatic-assign-of-product-source-code-when-create-it-through-po-is-broken
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't notice it at first but after QA Katarzyna pointed out that the format of generated identifier for product source didn't match the one that is on
developbranch so I compared both branches and in fact there was a difference in formatsopenboxes/src/groovy/org/pih/warehouse/core/Constants.groovy
Line 121 in 1e77b28
Based on commits I did not see any reasoning behind changing the format on
feature/upgrade-to-grails-3.3.10so I assume it was probably a mistake