OBGM-535 Fix synonyms import through edit product page#4168
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jul 17, 2023
Merged
OBGM-535 Fix synonyms import through edit product page#4168awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
Conversation
alannadolny
approved these changes
Jul 14, 2023
drodzewicz
approved these changes
Jul 14, 2023
awalkowiak
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that there is some difference between
MultipartHttpServletRequestimplementation in Grails 1 and Grails 3 and this is probably why it couldn't cast this class now.Since
CommonsMultipartFileis an implementation ofMultipartFileinterface:we can (and should) use it as a type here, since it is even more correct in terms of dependency inversion principle, and the error disappears and the import works correctly.