Skip to content

OBGM-535 Fix synonyms import through edit product page#4168

Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
OBGM-535
Jul 17, 2023
Merged

OBGM-535 Fix synonyms import through edit product page#4168
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
OBGM-535

Conversation

@kchelstowski
Copy link
Collaborator

It turned out that there is some difference between MultipartHttpServletRequest implementation in Grails 1 and Grails 3 and this is probably why it couldn't cast this class now.

Since CommonsMultipartFile is an implementation of MultipartFile interface:

public class CommonsMultipartFile implements MultipartFile, Serializable {

we can (and should) use it as a type here, since it is even more correct in terms of dependency inversion principle, and the error disappears and the import works correctly.

@awalkowiak awalkowiak merged commit 2399289 into feature/upgrade-to-grails-3.3.10 Jul 17, 2023
@awalkowiak awalkowiak deleted the OBGM-535 branch July 17, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants