OBGM-570 Fix replenishment not being saved on next step of replenishment workflow#4167
Merged
awalkowiak merged 3 commits intofeature/upgrade-to-grails-3.3.10from Jul 17, 2023
Conversation
drodzewicz
changed the title
kchelstowski
requested changes
Jul 13, 2023
| "/api/replenishments/$id/"(parseRequest: true) { | ||
| controller = { "replenishmentApi" } | ||
| action = [GET: "read", POST: "create", PUT: "update"] | ||
| action = [GET: "read", POST: "update"] |
Collaborator
There was a problem hiding this comment.
I'd rather change on the frontend side, that update method is called with PUT, instead of changing the mapping for not correct one regarding REST standards
Collaborator
Author
There was a problem hiding this comment.
sure, I guess PUT for an update makes much more sense than a POST.
I didn't want to do it since it does change the API a little bit and it seems that previously the POST method was used for update
| if (jsonObject.status) { | ||
| replenishment.status = ReplenishmentStatus.valueOf(jsonObject.status) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
out of curiosity - what problem did it cause? Is it binded correctly without that?
|
|
||
| order.save(failOnError: true) | ||
| if (order.hasErrors() || !order.save(failOnError: true)) { | ||
| throw new grails.validation.ValidationException("Invalid order", order.errors) |
Collaborator
There was a problem hiding this comment.
let's import the exception on top of the file, and call it throw new ValidationException for better visibility ;)
Collaborator
Author
There was a problem hiding this comment.
makes sense, will do
Collaborator
Author
|
This was an interesting case that I have never come across before. So in terms of code and URL mapping, there weren't any differences but there was one interesting behavior that I noticed on grails1 that caused this error to surface on grails 3. Below is a So after debugging the |
drodzewicz
requested review from
alannadolny,
awalkowiak,
jmiranda and
kchelstowski
awalkowiak
approved these changes
Jul 13, 2023
Member
|
@drodzewicz don't forget about these mappings |
jmiranda
requested changes
Jul 13, 2023
| "/api/replenishments/$id/"(parseRequest: true) { | ||
| controller = { "replenishmentApi" } | ||
| action = [GET: "read", POST: "create", PUT: "update"] | ||
| action = [GET: "read", PUT: "update"] |
Member
There was a problem hiding this comment.
Change POST to link to "update" action. It's not REST-compliant but it's what a developer would expect if they posted to an endpoint for a resource with an ID.
| const url = `/api/replenishments/${this.props.match.params.replenishmentId}`; | ||
| const payload = { status: 'COMPLETED' }; | ||
| apiClient.post(url, flattenRequest(payload)) | ||
| apiClient.put(url, flattenRequest(payload)) |
Member
There was a problem hiding this comment.
I'm ok with either post or put here, but we can tech-huddle this if necessary. Lazy developers like myself will exclusively use GET and POST when testing an API so I don't mind supporting that.
However, there are some resources where this would be confusing and unexpected so we should definitely be conscious of what we're doing and explicit / restrictive where possible.
Here's another long-winded argument for supporting either approach.
I don't yet know where I stand.
Member
|
@drodzewicz @awalkowiak @kchelstowski @alannadolny FWIW, you can regenerate a report of all URL mappings. However, I don't think this is any more helpful than the UrlMappings.groovy class. |
awalkowiak
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.