OBGM-575 Unable to create product source (fix for update and delete after QA)#4165
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jul 13, 2023
Merged
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
jmiranda and
kchelstowski
alannadolny
force-pushed
the
OBGM-575-fix
branch
from
e1fb384 to
0b4a619
Compare
awalkowiak
approved these changes
Jul 13, 2023
kchelstowski
approved these changes
Jul 13, 2023
drodzewicz
approved these changes
Jul 13, 2023
jmiranda
reviewed
Jul 13, 2023
|
|
||
| ProductSupplier saveProductSupplier(ProductSupplier productSupplier) { | ||
| return productSupplier.save() | ||
| if (!productSupplier.hasErrors()) { |
Member
There was a problem hiding this comment.
Why not just do this
return !productSupplier.hasErrors() && productSupplier.save(flush: true)
| return null | ||
| } | ||
|
|
||
| void deleteProductSupplier(ProductSupplier productSupplier) { |
Member
There was a problem hiding this comment.
I know for this case we do the lookup in the controller, but I think our service layer should allow a delete by ID. For now, we can add that method when we need it. I just wanted to make sure that I set expectations.
void deleteProductSupplier(String id) {
ProductSupplier productSupplier = ProductSupplier.get(id)
productSupplier.delete()
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.