OBGM-575 Unable to create product source #4157
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jul 13, 2023
Merged
OBGM-575 Unable to create product source #4157awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
jmiranda and
kchelstowski
kchelstowski
approved these changes
Jul 11, 2023
drodzewicz
reviewed
Jul 11, 2023
Collaborator
drodzewicz
left a comment
drodzewicz
left a comment
There was a problem hiding this comment.
I believe you will get some pushback from Justin on creating new services just for this save action, in my opinion, a more generic approach would be better like using GenericApiService
I started a conversation thread about this topic under Kacpers PR, so let's resolve it there and then we can proceed with the changes
awalkowiak
approved these changes
Jul 13, 2023
Collaborator
|
As @alannadolny suggests there is more logic that could be moved to this service from that controller (for example entire get list logic) I am merging this as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.