OBGM-565 Fix accessing nested map values#4155
Merged
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from Jul 13, 2023
Merged
Conversation
drodzewicz
requested review from
alannadolny,
awalkowiak,
jmiranda and
kchelstowski
alannadolny
approved these changes
Jul 10, 2023
drodzewicz
added
the
warn: do not merge
drodzewicz
force-pushed
the
OBGM-565-items-removed-from-shipment-when-edit-qty-on-pick-page
branch
from
13a49f4 to
67512ba
Compare
drodzewicz
removed
the
warn: do not merge
awalkowiak
approved these changes
Jul 13, 2023
awalkowiak
deleted the
OBGM-565-items-removed-from-shipment-when-edit-qty-on-pick-page
branch
jmiranda
reviewed
Jul 13, 2023
| bindReplenishmentData(replenishment, currentUser, currentLocation, jsonObject) | ||
| Order order = replenishmentService.createOrUpdateOrderFromReplenishment(replenishment) | ||
| if (order.hasErrors() || !order.save(flush: true)) { | ||
| if (order.hasErrors()) { |
Member
There was a problem hiding this comment.
We should not be doing that check here in the controller. I think I saw that this was moved to the service in another PR and I just wanted to mention that I think is the proper approach.
|
|
||
| Replenishment bindReplenishmentData(Replenishment replenishment, User currentUser, Location currentLocation, JSONObject jsonObject) { | ||
| bindData(replenishment, jsonObject) | ||
| bindData(replenishment, jsonObject, [exclude: ['replenishmentItems']]) |
Member
There was a problem hiding this comment.
A comment would be helpful here so we know why the exclude is being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.