OBGM-558 Fix accessing nested map values#4153
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jul 10, 2023
Merged
Conversation
drodzewicz
commented
Jul 10, 2023
| // Bind the container | ||
| PartialReceiptContainer partialReceiptContainer = | ||
| partialReceipt.findPartialReceiptContainer(containerMap["container.id"]) | ||
| partialReceipt.findPartialReceiptContainer(containerMap.container?.id) |
Collaborator
Author
There was a problem hiding this comment.
I have come across this issue already several times where we are trying to access nested map values using strings like
map["key1.key2.key3"] or map.get("key1.key2.key3").
I guess the newest version of Groovy has removed this feature so the alternative way is to use the key chaining with null safety.
I was thinking of maybe creating a spike ticket to investigate and fix places where this exact problem can be found, but I am not sure if it is a good idea. I guess we'll talk about it in the tech-hiddle
awalkowiak
approved these changes
Jul 10, 2023
awalkowiak
deleted the
OBGM-558-unable-to-receive-when-packing-levels-added
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.