OBGM-578:583 Add Transactional on controller actions that require it#4148
Merged
awalkowiak merged 6 commits intofeature/upgrade-to-grails-3.3.10from Jul 7, 2023
Merged
OBGM-578:583 Add Transactional on controller actions that require it#4148awalkowiak merged 6 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 6 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
awalkowiak
requested review from
alannadolny,
drodzewicz,
jmiranda and
kchelstowski
drodzewicz
approved these changes
Jul 7, 2023
Collaborator
drodzewicz
left a comment
drodzewicz
left a comment
There was a problem hiding this comment.
Since Justin advised against creating a separate service for each domain adding @transactional should be good enough for this moment.
Fingers crossed that this does not cause problems in the future 🤞
kchelstowski
approved these changes
Jul 7, 2023
Collaborator
kchelstowski
left a comment
kchelstowski
left a comment
There was a problem hiding this comment.
we all know it's not the best approach, but I guess it could wait until MVP instead of spending time figuring out what services we should create or we shouldn't create for those micro classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.