OBGM-413 Unable to create a new user#4146
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jul 7, 2023
Merged
OBGM-413 Unable to create a new user#4146awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
Conversation
awalkowiak
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to discussions we had both here: #4093 and in the ticket for now I went the easiest path, so just to make the persistence in the service layer.
I think doing data binding in the controller is not that bad, since in spring we also use @RequestBody to do it for us, but eventually in the MVP1/2 we could follow path of creating DTOs for those, so to make
but user is specific case. But I believe this would be still a better approach instead of extracting a lot of params and passing it to the service etc.
I'm looking forward to discuss it in the future.