OBGM-574 Disable allow_update_outside_transaction Hibernate setting#4136
Merged
kchelstowski merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jul 4, 2023
Merged
OBGM-574 Disable allow_update_outside_transaction Hibernate setting#4136kchelstowski merged 1 commit intofeature/upgrade-to-grails-3.3.10from
kchelstowski merged 1 commit intofeature/upgrade-to-grails-3.3.10from
Conversation
Collaborator
Author
|
I'm merging this one - the faster we find bugs related to that, the better. |
jmiranda
reviewed
Jul 6, 2023
Member
jmiranda
left a comment
There was a problem hiding this comment.
Agree with @kchelstowski that we should be setting configuration explicitly (with very descriptive commit messages).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know I could've deleted this setting at all, but I prefer to leave it with the
falseflag, because figuring out what Hibernate settings for an exact version are enabled/disabled by default, is a pain in the neck, so it will provide a better readability and understanding, what is enabled/disabled