OBGM-552 Unable to add items to PO through import#4131
Merged
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from Jul 4, 2023
Merged
OBGM-552 Unable to add items to PO through import#4131awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 2 commits intofeature/upgrade-to-grails-3.3.10from
Conversation
kchelstowski
approved these changes
Jun 30, 2023
jmiranda
approved these changes
Jul 1, 2023
Member
jmiranda
left a comment
jmiranda
left a comment
There was a problem hiding this comment.
LTGM, I guess.
However, I don't really understand how the fix solves the problem because it's not obvious what is happening.
@alannadolny could you please explain the issue in the ticket. What is different about YML that causes the issue. And also make sure this works if we were to override the configuration in openboxes-config.groovy.
awalkowiak
requested changes
Jul 3, 2023
| if (existingValue != importedValue) { | ||
| throw new IllegalArgumentException("Import must not change ${property} of item ${orderItem.productCode}, before: ${existingValue}, after: ${importedValue}") | ||
| } | ||
| propertiesMap.deny.each { property -> |
Collaborator
There was a problem hiding this comment.
Can you move propertiesMap.deny to the excludedProperties variable, and make it nullsafe? In case someone removes it from the config?
awalkowiak
approved these changes
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.