Skip to content

OBGM-505 Unable to add items and adjustments to PO#4119

Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
OBGM-505
Jun 21, 2023
Merged

OBGM-505 Unable to add items and adjustments to PO#4119
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
OBGM-505

Conversation

@alannadolny
Copy link
Collaborator

No description provided.

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<meta name="layout" content="custom" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meta tag doesn't apply the layout on those two files. During searching for possible solutions/problems to solve, I found this stackOverflow discussion which is not too much connected to this issue, but I found there g:applyLayout and it works as it should.

* TODO localized strings? Further discussion at OBGM-343.
*/
if ($("#validationCode").val() == 'WARN' && !confirm(_.escape(htmlDecode("${g.message(code: 'orderItem.warningSupplier.label')}")))) {
if ($("#validationCode").val() == 'WARN' && !confirm(htmlDecode("${g.message(code: 'orderItem.warningSupplier.label')}"))) {
Copy link
Collaborator Author

@alannadolny alannadolny Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing the lodash library was throwing an error. After removing it I found there is a reference to global UMD variable. After checking how this message looks like I found that, it's broken:
image
There was a ticket about the quotes.
After removing this method from lodash I found that this message looks correct:
image
In the comment above this code is a comment about further discussion/investigation about it.
Here is the ticket

Copy link
Collaborator

@awalkowiak awalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is a correct usage of applyLayout in gsp templates, but since it works and unblocks work I am merging it

@awalkowiak awalkowiak merged commit 86b6bd7 into feature/upgrade-to-grails-3.3.10 Jun 21, 2023
@awalkowiak awalkowiak deleted the OBGM-505 branch June 21, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants