OBGM-486 Unable to upload documents on view shipment page#4108
Merged
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from Jun 16, 2023
Merged
OBGM-486 Unable to upload documents on view shipment page#4108awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
awalkowiak merged 1 commit intofeature/upgrade-to-grails-3.3.10from
Conversation
awalkowiak
requested changes
Jun 15, 2023
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
I did this regex search in grails-app folder: log\.(info|debug|error)[ |(][^\"|^\'] and there are also two instances of log.debug params plus a couple of instances of logging maps. Please change the "debug params" and check if Map also triggers this issue.
alannadolny
commented
Jun 15, 2023
Comment on lines
49
to
53
| def showCacheStatistics() { | ||
| def statistics = sessionFactory.statistics | ||
| log.info(statistics) | ||
| log.info("${statistics}") | ||
| render statistics | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I am not sure if this method is used somewhere
kchelstowski
approved these changes
Jun 15, 2023
Collaborator
kchelstowski
left a comment
kchelstowski
left a comment
There was a problem hiding this comment.
it LGTM, but I'm actually wondering if you have a clear answer why it is not working and has worked for Grails 1? What changed?
Collaborator
Author
awalkowiak
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.