OBGM-453 / OBGM-411 Unable to go forward/backward in outbound returns and product searches not working #4090
Merged
awalkowiak merged 3 commits intofeature/upgrade-to-grails-3.3.10from Jun 7, 2023
Merged
Conversation
alannadolny
changed the title
awalkowiak
force-pushed
the
feature/upgrade-to-grails-3.3.10
branch
from
019c8a8 to
7e46d89
Compare
jmiranda
added
the
warn: do not merge
Member
|
This one needs to be rebased. |
…rward and backward
alannadolny
removed
the
warn: do not merge
kchelstowski
reviewed
Jun 7, 2023
|
|
||
| def publishRefreshEvent = { | ||
| Holders.grailsApplication.mainContext.publishEvent(new RefreshProductAvailabilityEvent(this)) | ||
| applicationEventPublisher?.publishEvent(new RefreshProductAvailabilityEvent(this)) |
Collaborator
There was a problem hiding this comment.
I think this refactor was not needed. Was it?
Collaborator
Author
There was a problem hiding this comment.
You are right. Previously, without those changes, I got an error about it. For now, I reverted those changes and it works fine, thanks.
| import NotificationType from 'consts/notificationTypes'; | ||
|
|
||
| const justRejectRequestError = error => Promise.reject(error); | ||
| const justRejectRequestError = (error) => Promise.reject(error); |
Collaborator
There was a problem hiding this comment.
seems like ESLint rules have changed that he shouted for this? Or have you done it manually?
Collaborator
Author
There was a problem hiding this comment.
Yes, I used 'fix all' eslint problems when I was working on this file and it added those brackets.
kchelstowski
approved these changes
Jun 7, 2023
awalkowiak
requested changes
Jun 7, 2023
| createAlias('productSuppliers.manufacturer', 'psm', JoinType.LEFT_OUTER_JOIN) | ||
| createAlias('productSuppliers.supplier', 'pss', JoinType.LEFT_OUTER_JOIN) | ||
| createAlias('inventoryItems', 'ii', JoinType.LEFT_OUTER_JOIN) | ||
| createAlias('synonyms', 'syn', JoinType.LEFT_OUTER_JOIN) |
src/js/utils/apiClient.jsx
Outdated
| return Promise.reject(error); | ||
| }; | ||
|
|
||
| export const unflatten = (flattened) => { |
Collaborator
There was a problem hiding this comment.
Is not parseResponse for this purpose?
awalkowiak
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.