Conversation
| } | ||
|
|
||
| // TODO: OBAM-169: Remove user modified picklist for given orderItem | ||
| // replenishmentService.removePicklist(orderItem) |
There was a problem hiding this comment.
Can you explain the commented out code?
There was a problem hiding this comment.
Each order item in the replenishment will be auto-picked at first, and then the user will have an option to change the pick or go back to the auto-pick (it is the same as currently existing picking for requisitions). These lines are commented out because the auto picking and picking is not yet implemented and it should be added in the mentioned ticket (or in OBAM-173).
grails-app/conf/UrlMappings.groovy
Outdated
| action = [DELETE: "removeItem"] | ||
| } | ||
|
|
||
| "/api/replenishments/$id/createPicklist"(parseRequest: true) { |
There was a problem hiding this comment.
I'd like to avoid remote procedure call naming convention so let's go with a subresource. I can't tell if we want the subresource should be picklist or picklistItems.
"/api/replenishments/$id/picklists"(parseRequest: true) {
controller = { "replenishmentApi" }
action = [POST: "createPicklist", PUT: "updatePicklist", DELETE: "deletePicklist"]
}
There was a problem hiding this comment.
My guess would be picklistItems as the subresource and methods could be createPicklistItems, updatePicklistItems, deletePicklistItems.
| * You must not remove this notice, or any other, from this software. | ||
| **/ | ||
| package replenishment | ||
| package org.pih.warehouse.replenishment |
There was a problem hiding this comment.
thank you. i just noticed this last night when i was browsing the code for something else.
2 participants
No description provided.