Fix for exceptions on install if .env files are missing#135
Closed
evosite-ltd wants to merge 1 commit intoopenai-php:mainfrom
Closed
Fix for exceptions on install if .env files are missing#135evosite-ltd wants to merge 1 commit intoopenai-php:mainfrom
evosite-ltd wants to merge 1 commit intoopenai-php:mainfrom
Conversation
It's common to use env.{environment-name} and when that's the case, the installer throws exceptions which this resolves.
Fixes openai-php#120
iBotPeaches
reviewed
Mar 19, 2025
Collaborator
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
Do you feel we should just swallow this error? The install command then looks to work, but didn't touch either file.
What about a little warning emitted saying "File not found" for those respective ones so those with a non-standard setup could see it and adapt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's common to use env.{environment-name} and when that's the case, the installer throws exceptions which this resolves.
Fixes #120