Repository navigation
Escape timestamp arrows in word-level subtitles - #2847
Open
codewithfourtix wants to merge 2 commits into
Open
codewithfourtix wants to merge 2 commits into
codewithfourtix wants to merge 2 commits into
Conversation
Signed-off-by: Ali Zulfiqar <[email protected]>
There was a problem hiding this comment.
🟡 Changes recommended
The new regression test does not currently verify the “input timings remain unchanged” claim from the PR description, so the test coverage doesn’t fully match the stated acceptance criteria.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR ensures word-level subtitle output (SRT/VTT) escapes the --> timestamp arrow sequence inside subtitle text (word cues and highlighted-word cues), aligning behavior with existing segment-level subtitle escaping.
Changes:
- Escape
-->to->in each word’s text before assembling word-level subtitle cues. - Add regression tests covering both SRT and VTT writers, with and without
highlight_words.
File summaries
| File | Description |
|---|---|
| whisper/utils.py | Escapes --> in word-level cue text before line splitting / cue assembly. |
| tests/test_subtitle_arrows.py | Adds a regression test ensuring word-level subtitle text does not contain --> for both writers and highlight modes. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Ali Zulfiqar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segment-level subtitles already replace
-->in transcript text, but word-level subtitles leave it intact. Apply the same escaping before assembling word-level cues, including highlighted words.Adds SRT and VTT regressions and checks that the input timings remain unchanged.