Repository navigation
Keep each transcript segment on one TSV row - #2846
Open
codewithfourtix wants to merge 2 commits into
Open
codewithfourtix wants to merge 2 commits into
codewithfourtix wants to merge 2 commits into
Conversation
Signed-off-by: Ali Zulfiqar <[email protected]>
There was a problem hiding this comment.
🟢 Approval recommended
The change directly addresses the TSV row-splitting issue and includes focused regression tests for the relevant control-character cases.
Pull request overview
This PR hardens the TSV transcript writer so each segment is always emitted as a single TSV row by normalizing embedded control characters in segment text, preventing timestamp-less “extra rows” in downstream TSV consumers.
Changes:
- Replace
\rand\nin TSV segment text with spaces (in addition to existing tab handling). - Add pytest coverage for LF, CR, CRLF, and tab characters in segment text.
File summaries
| File | Description |
|---|---|
| whisper/utils.py | Normalizes newline/carriage return characters in TSV output to keep segments on one row. |
| tests/test_tsv_writer.py | Adds regression test ensuring segment text with LF/CR/CRLF/tab stays on a single TSV row. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Ali Zulfiqar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded newlines in segment text create extra rows in TSV output without timestamps. Replace carriage returns and newlines with spaces, as the writer already does for tabs.
Adds coverage for LF, CR, CRLF, and tab characters.