Repository navigation
fix: validate workload identity access tokens - #1885
Merged
HAYDEN-OAI merged 3 commits intoJun 24, 2026
Merged
Conversation
HAYDEN-OAI
approved these changes
Jun 24, 2026
Contributor
|
@pragnyanramtha thanks again for catching this and tightening the auth boundary so malformed token responses fail cleanly. really appreciate the careful work here. merging now! 💚 |
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAIErrorwhen a 200 response omits or returns an emptyaccess_tokenexpires_inbehavior while respecting explicit0with nullish coalescingWhy
A malformed token exchange success response was previously trusted and cached. If
access_tokenwas absent,getToken()could returnundefined, allowing downstream requests to construct an invalid bearer token instead of failing at the authentication boundary.Validation
yarn test tests/auth/workload-identity-auth.test.ts --runInBandyarn test tests/lib/workload-identity.test.ts --runInBand./node_modules/.bin/prettier --check src/auth/workload-identity-auth.ts tests/auth/workload-identity-auth.test.ts./node_modules/.bin/eslint src/auth/workload-identity-auth.ts tests/auth/workload-identity-auth.test.ts./scripts/buildgit diff --check