Repository navigation
docs: explain buffered native Responses - #5590
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the configuration guide against implementation PR #5589 at 1aca01e with an independent reviewer. No actionable findings. Full-body output/tool timing, API-key HTTP requirements, explicit standard Responses model, unsupported combinations, failure semantics and current-provider restore selection match the implementation. Approval is for content; retain the stated merge gate until a published preview includes buffered support. Hosted CI: 11 passed, 10 skipped, 1 neutral, 1 running. Static review only; no candidate code or tests executed locally.
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
The new size-limit sentence is not supported by implementation PR #5589 at 1369f2e. Independent static review confirmed the mismatch. Remove the claim or supply the matching implementation for review before publishing it. The existing published-preview merge gate still applies. Hosted CI is still pending; no candidate code or tests executed locally.
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
The documentation mismatch is resolved by implementation #5589 at a006551. Coordinator and independent static review verified the 64 MiB transport bound and non-retryable oversize handling. Approval is for content: retain the merge hold until a published preview includes the feature and this fix. Hosted CI: 13 passed, 16 skipped. No candidate code or tests executed locally.
|
@codex review |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed 450d777 with an independent static reviewer. The updated guide accurately describes the one-million outside-string structural-character limit and 64 MiB body limit implemented in #5589 at 678ec3a, including non-retryable rejection. No new blockers in this documentation change. Keep the existing merge hold until a published preview contains the implementation and both limits. Hosted CI remains pending (10 passed, 10 skipped, 1 neutral, 2 running at review). No local tests run.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 450d7770dc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@jbeckwith-oai The earlier description overstated the documentation policy as a mandatory published-release gate. AGENTS.md requires a separate docs PR so maintainers can coordinate timing. This PR targets Proposed sequence: merge #5589 after its final verification and CI pass, then merge this guide into the same development branch. That puts the matching implementation and both response limits on the branch without publishing a release or deploying the hosted docs. Please confirm whether your content approval covers this sequence and removes the earlier published-preview condition. The existing hold remains until that is confirmed. |
Summary
This is the documentation follow-up to #5589. The existing published-preview hold remains pending the reviewer's confirmation of the proposed sequence: merge after #5589 into the development branch. This branch does not deploy the hosted documentation.
The guide explains
NativeProvider(response_mode="buffered"), delayed model output and tool-call start, supported models and authentication, and the provider's role when restoring a session. It documents the 64 MiB body limit and the limit of one million structural characters outside strings, with nonretryable failures.The implementation is reviewed separately in #5589 at
678ec3a232da3cfed578a43939f8f03a838b1e14; its provider option and native transport changes are intentionally kept in that PR.Test plan
make build-docsandgit diff --checkpassed on the current documentation.450d7770: 13 checks succeeded and 16 were skipped. Hosted review is clean, with no unresolved review threads. The published-preview merge hold remains in force.Issue number
None linked.
Checks
AGENTS.md, including.agents/skills/code-change-verification/scripts/run.shwhen requiredAGENTS.md