Repository navigation
Add native file search, Code Interpreter, and image tools - #5576
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca3ba27c44
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Please address the existing documentation-timing finding: #5576 (comment) . AGENTS.md explicitly requires docs/ content for unreleased behavior to be a separately timed docs-only change. Remove this new docs/sdk/tools.md section from the feature PR and retain the accompanying examples. This is a P2 delivery-policy correction, not a P1 runtime defect.
Coordinator and independent static review found no additional actionable code defects across the shared Core patch, hosted tool configuration, provider payload/history/restore preservation, child sessions, progress buffering, cancellation and completion continuation. Hosted native-platform CI and Rust CodeQL remain pending. No candidate code or tests executed.
ca3ba27 to
6943280
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
The documentation blocker is resolved: the unreleased guide section is removed from this feature PR. The rebased production feature patch is equivalent apart from patch numbering/series baselines; the hosted Core patch checksum is unchanged. Reviewed the new integration coverage for captured configuration, provider transport reuse and session isolation, large previews, cancellation/recovery, and completed hosted results preceding provider failure.
Coordinator and independent static re-review found no actionable source findings. No candidate code or tests executed locally. Current-head platform CI and CodeQL remain pending. This approval does not establish resolution of the previous macOS child.turn failure: retain the merge/release hold until a clean current-head macOS run and remaining validation complete.
Summary
This pull request adds
FileSearch,CodeInterpreter, andImageGenerationto native sessions. Core sends their declarations through the Responses loop and retains the provider's results. Sessions capture the configuration when they open; later tool selections can retain or omit those grants.Expose typed file search, code, and image results through history, including citations and raw provider fields. Preserve final items through restore, and deliver code progress and partial images through bounded observations. Child sessions inherit the selected grants. Responses containing only hosted tool results can complete without assistant text. Completion callbacks can continue the same turn while preserving those results.
Include examples and an updated API snapshot for the added native exports. The user guide is in the separate docs PR #5578. Existing release metadata stays unchanged.
Test plan
The local run used the standard Codex sandbox exclusions and
NODE_NO_WARNINGS=1for this host's injected Node proxy warning. Live provider calls and the excluded platform sandbox checks were not run.Issue number
None.
Checks
AGENTS.md, including.agents/skills/code-change-verification/scripts/run.shwhen requiredAGENTS.md