Repository navigation
feat: expose passive request metadata and response links - #5519
markstuart-oai merged 2 commits into
Conversation
efa3e9a to
a776c72
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved after coordinator and independent static review. Request metadata follows the selected client fields, uses a bounded nonblocking queue and stays attached to the original submission/thread. Response links use retained occurrence IDs; restored manual work binds a fresh route. Delivery remains passive and best effort, with no execution authority. Inherited response-history implementation matches the previously reviewed #5512 blobs.
Hosted CI remains pending. Static review only; no candidate code or local tests ran.
31aad04 to
84874fb
Compare
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the base integration using exact tree comparisons and the remaining overlapping source. Request metadata retains its bounded passive queue, exact submission routing, and dispatch after sampling-stop/admission checks. The metadata patch changes only rebase context and offsets. No new findings. Hosted native CI is pending. Static review with independent review; no local tests executed.
d16cd3f
into
codex/native-response-history
* Preserve received response history on current v1 * feat: expose passive request metadata and response links (#5519) Observe passive request metadata on repaired history Co-authored-by: markstuart-oai <[email protected]> --------- Co-authored-by: markstuart-oai <[email protected]>
* Preserve received response history on current v1 * fix: preserve trace context on repaired history base * Preserve defined trace flags and manual action budgets * Sequence trace regression tool replies before final model output * feat: expose passive request metadata and response links (#5519) Observe passive request metadata on repaired history Co-authored-by: markstuart-oai <[email protected]> * Validate native trace prefix widths and fresh-root controls * Align manual continuation trace and observation arguments * Fix worker deadline fixtures and Windows storage type checks * Verify the winning reply when manual responses race * Check complete trace handles and both MCP callback parents * Observe child turns before testing unconfirmed cancellation * Respect supported platforms in SQLite trace fixtures * Distinguish caller exports from disabled child work * Preserve native child callback tracing ownership * Distinguish child trace exports and surface callback failures * Keep remote trace ancestry separate from private SDK policy * Preserve owned child tracing policy across native admission * Avoid callback scheduling assumptions in trace policy test * Separate session setup from concurrent trace policy admissions * Account for split trace processor batches in loop-loss test --------- Co-authored-by: markstuart-oai <[email protected]>
* Expose typed reasons for owned model output failures * Handle the expected parser disconnect in the reason fixture * Preserve received response history on current v1 * fix: preserve trace context on repaired history base * Fix CI assumptions about child snapshots and temporary directories * Preserve defined trace flags and manual action budgets * Sequence trace regression tool replies before final model output * feat: expose passive request metadata and response links (#5519) Observe passive request metadata on repaired history Co-authored-by: markstuart-oai <[email protected]> * Keep integrity reason tests within the native enum contract * Validate native trace prefix widths and fresh-root controls * Align manual continuation trace and observation arguments * Fix worker deadline fixtures and Windows storage type checks * Verify the winning reply when manual responses race * Check complete trace handles and both MCP callback parents * Observe child turns before testing unconfirmed cancellation * Respect supported platforms in SQLite trace fixtures * Distinguish caller exports from disabled child work * Preserve native child callback tracing ownership * Distinguish child trace exports and surface callback failures * Keep remote trace ancestry separate from private SDK policy * Preserve owned child tracing policy across native admission * Avoid callback scheduling assumptions in trace policy test * Separate session setup from concurrent trace policy admissions * Account for split trace processor batches in loop-loss test * Wait for a pending observation read before cancellation * Wait for asynchronous release command before checking child retirement --------- Co-authored-by: markstuart-oai <[email protected]>
…5517) * fix: report captured context limits and model defaults * Expose typed reasons for owned model output failures * Handle the expected parser disconnect in the reason fixture * Report the compactor's context window on terminal overflow * Preserve received response history on current v1 * Fill overflow usage from the model that sampled the request * Import the types and assertions used by context metadata tests * fix: preserve trace context on repaired history base * Fix CI assumptions about child snapshots and temporary directories * Preserve defined trace flags and manual action budgets * Sequence trace regression tool replies before final model output * feat: expose passive request metadata and response links (#5519) Observe passive request metadata on repaired history Co-authored-by: markstuart-oai <[email protected]> * Keep integrity reason tests within the native enum contract * Validate native trace prefix widths and fresh-root controls * Align manual continuation trace and observation arguments * Fix worker deadline fixtures and Windows storage type checks * Verify the winning reply when manual responses race * Check complete trace handles and both MCP callback parents * Observe child turns before testing unconfirmed cancellation * Respect supported platforms in SQLite trace fixtures * Distinguish caller exports from disabled child work * Preserve native child callback tracing ownership * Distinguish child trace exports and surface callback failures * Keep remote trace ancestry separate from private SDK policy * Preserve owned child tracing policy across native admission * Avoid callback scheduling assumptions in trace policy test * Separate session setup from concurrent trace policy admissions * Account for split trace processor batches in loop-loss test --------- Co-authored-by: markstuart-oai <[email protected]>
* fix: report captured context limits and model defaults * feat: edit detached native sampling requests * Expose typed reasons for owned model output failures * Report prepared-request mid-turn compaction failures * Handle the expected parser disconnect in the reason fixture * Report the compactor's context window on terminal overflow * Borrow the sampling prompt when no request editor is active * Preserve received response history on current v1 * Fill overflow usage from the model that sampled the request * Import the types and assertions used by context metadata tests * fix: preserve trace context on repaired history base * Validate prepared requests against the selected tool roster * Fix CI assumptions about child snapshots and temporary directories * Preserve defined trace flags and manual action budgets * Sequence trace regression tool replies before final model output * Preserve explicit provider overrides in request editor preflight * Keep request editor forwarding optional for run_sync overrides * feat: expose passive request metadata and response links (#5519) Observe passive request metadata on repaired history Co-authored-by: markstuart-oai <[email protected]> * Keep integrity reason tests within the native enum contract * Let the turn report fatal prepared-request compaction once * Validate native trace prefix widths and fresh-root controls * Validate sampled manual tools and retain request callback tracing * Align manual continuation trace and observation arguments * Fix worker deadline fixtures and Windows storage type checks * Preserve existing submit overrides on ordinary agent runs * Verify the winning reply when manual responses race * Check complete trace handles and both MCP callback parents * Observe child turns before testing unconfirmed cancellation * Respect supported platforms in SQLite trace fixtures * Distinguish caller exports from disabled child work * Preserve native child callback tracing ownership * Distinguish child trace exports and surface callback failures * Keep remote trace ancestry separate from private SDK policy * Preserve owned child tracing policy across native admission * Avoid callback scheduling assumptions in trace policy test * Separate session setup from concurrent trace policy admissions * Account for split trace processor batches in loop-loss test * fix: preserve completed answers when request editing skips compaction --------- Co-authored-by: markstuart-oai <[email protected]>
#5516) * Stop sampling retries after terminal authentication failure * fix: report captured context limits and model defaults * feat: edit detached native sampling requests * Expose typed reasons for owned model output failures * Report prepared-request mid-turn compaction failures * Initialize the receipt field in the protocol test fixture * Handle the expected parser disconnect in the reason fixture * Report the compactor's context window on terminal overflow * Borrow the sampling prompt when no request editor is active * Preserve received response history on current v1 * Fill overflow usage from the model that sampled the request * Share bounded authentication recovery across fallback * Import the types and assertions used by context metadata tests * fix: preserve trace context on repaired history base * Validate prepared requests against the selected tool roster * Validate rotated credentials in native recovery tests * Fix CI assumptions about child snapshots and temporary directories * Preserve defined trace flags and manual action budgets * Sequence trace regression tool replies before final model output * Distinguish preconnect and sampling authentication recovery tests * Preserve explicit provider overrides in request editor preflight * Keep request editor forwarding optional for run_sync overrides * feat: expose passive request metadata and response links (#5519) Observe passive request metadata on repaired history Co-authored-by: markstuart-oai <[email protected]> * Keep integrity reason tests within the native enum contract * Let the turn report fatal prepared-request compaction once * Validate native trace prefix widths and fresh-root controls * Validate sampled manual tools and retain request callback tracing * Align manual continuation trace and observation arguments * Fix worker deadline fixtures and Windows storage type checks * Preserve existing submit overrides on ordinary agent runs * Verify the winning reply when manual responses race * Check complete trace handles and both MCP callback parents * Observe child turns before testing unconfirmed cancellation * Respect supported platforms in SQLite trace fixtures * Distinguish caller exports from disabled child work * Preserve native child callback tracing ownership * Distinguish child trace exports and surface callback failures * Keep remote trace ancestry separate from private SDK policy * Preserve owned child tracing policy across native admission * Avoid callback scheduling assumptions in trace policy test * Separate session setup from concurrent trace policy admissions * Account for split trace processor batches in loop-loss test * fix: preserve completed answers when request editing skips compaction --------- Co-authored-by: markstuart-oai <[email protected]>
Summary
Requirement: REQ742 (observed reasoning settings) and REQ421 (links to retained received responses). Model-catalog accuracy, broader route coverage, and accounting acceptance remain separate.
This pull request adds passive request observations to managed root turns on top of #5512. Events report the model, reasoning settings, service tier, wire format, and transport passed to the selected native client. Response links use retained occurrence IDs, so repeated provider response IDs stay distinct.
Delivery is bounded and best effort. Manual restore binds a fresh observation route. These events are transient and grant no execution authority. Native children, warmup, reviewer requests, and compaction are outside this event's coverage.
Test plan
44e61bfecarries the upstream worker-example verification fix from its repaired history parent. API generation and native wheel qualification passed. Metadata code, production Python, native inputs and Core tree are unchanged from the authenticated84874fbcLinux product.Issue number
REQ742 and REQ421. Stacked on #5512.
Checks
AGENTS.md, including.agents/skills/code-change-verification/scripts/run.shwhen requiredAGENTS.md