Repository navigation
Allow Rust analysis and cold macOS native builds to finish - #5504
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved at c50f179. Independently reviewed both workflow timeout expressions and their matrix/input context: Rust CodeQL gets180 minutes while other languages retain45; macOS joins Windows at180 minutes while Linux retains100. No permission, trigger, or execution changes. No actionable findings.
Static review only; no candidate code or tests run. Hosted lint/docs/non-Rust CodeQL passed; Rust CodeQL and native builds remain pending. Leave unmerged as requested.
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
c50f179 to
eb24907
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the exact change from the previously reviewed commit: the only change raises the macOS native test step from 10 to 20 minutes. This addresses the observed hosted timeout without changing test assertions or execution behavior. No new findings.
Reviewed commit: eb249076900f13c1a7d9783203fb91818ef59b7d. Static review only; no candidate code or tests executed locally. Hosted CI is still running: CodeQL (rust), native-linux / Native package (ubuntu-24.04), native-macos / Native package (macos-latest), native-windows / Native package (windows-latest). No current hosted failures observed.
eb24907 to
c81aec7
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved at c81aec7. Reviewed the incremental Linux/Windows runner routing and matching change-detection assertions against the previously reviewed commit; no new correctness or security findings. Runtime code is unchanged. Hosted CI is still pending. Static review only; no candidate code or local tests executed.
Review stack: #5504 (CI) > #5499 (turn controls) > #5500 (receipts) > #5501 (executor) > #5502 (recovery) > #5503 (example) > #5495 (docs). Combined reference: #5494.
Requirements · CI verification for local execution and policy enforcement (
REQ732) and execution receipts (REQ734).Summary
Rust CodeQL and cold macOS native package builds get 180 minutes. Both had timed out during supervised-worker verification. The macOS SDK test step gets 20 minutes to run the main suite and the sandbox suite. Its 10-minute deadline expired just as the second suite finished.
Test plan
The failed macOS job reported 3,550 passing tests in the main suite and 41 in the sandbox suite. Together they took over ten minutes. I parsed the updated workflow and checked that the test step still runs both suites with the same commands. macOS job log
Issue number
The owning requirement IDs appear above.