Repository navigation
fix(ci): deploy docs after dependency and workflow updates - #4976
Conversation
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.16 to 9.7.7. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.6.16...9.7.7) --- updated-dependencies: - dependency-name: mkdocs-material dependency-version: 9.7.7 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60fbd0e790
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HAYDEN-OAI
left a comment
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
No actionable findings in the complete four-file diff at 9ee753346d4199b0bda9b8c5c64b6013543fffed. The previous redeployment concern is addressed: uv.lock selects the docs build and main-branch deployment even in mixed pushes, while missing commits or failed diffs still deny deployment. Pushes without a lockfile change retain the existing docs-only behavior.
Reviewed the detector and its callers, workflow privilege boundaries, complete lockfile changes, current docs configuration, and published Material 9.7.7 artifacts. The non-Material marker edits preserve reachable Python environments; the retained dependencies satisfy the upgraded theme's requirements. Both Material artifact hashes match the lockfile and PyPI metadata. The published search-suggestion advisory is fixed in 9.7.7, but search.suggest is not enabled here, so this review does not establish that the prior site was exploitable.
Static source/metadata/artifact review only. No installation, builds, tests, lint, CI or mergeability assessment, workflow execution, or live deployed-asset verification. Published provenance metadata was inspected, not its complete Sigstore certificate/transparency chain.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
No actionable findings in the four-file diff at 9ee753346d4199b0bda9b8c5c64b6013543fffed. Reviewed the dependency update, docs build/deployment triggers, mixed lockfile pushes, and failure handling. The implementation preserves docs-only deployment behavior when no lockfile changes are present and refuses deployment when commit/diff evidence is unavailable.
Validation: 41 independent synthetic detector cases passed; all 22 hosted checks succeeded. The docs build installed Material 9.7.7 and completed. No local dependency installation or live deployment was performed.
|
@dependabot rebase plz |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
@jbeckwith-oai Once the conflicts are resolved, this looks good to me
07a0d59
jbeckwith-oai
changed the title
SummaryThis pull request fixes docs deployment after dependency lockfile changes. Changes to Merged current Test plan
Checks
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07a0d59e60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: 07a0d59e60
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
jbeckwith-oai
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 901e5c81c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
This pull request fixes docs deployment after dependency and deployment-workflow updates. Changes to
uv.lockor.github/workflows/docs.ymlselect docs build and publication even in mixed pushes, so this workflow fix itself publishes the Material 9.7.7 assets already locked on main. Other pushes retain the existing docs-only policy, and missing or failed commit/diff evidence cannot authorize deployment.Dependency installation and the frozen docs build run with
contents: readand no persisted checkout credentials. A separatecontents: writejob downloads the same-run static artifact and publishes it to the existinggh-pagesbranch without installing dependencies or executing artifact code. Static copying excludes Git metadata. Runs are serialized with queued runs retained.No SDK runtime, dependency, or hosting configuration changes.
Test plan
make build-docspassed with Material 9.7.7.Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR