Repository navigation
fix(voice): honor client config for streamed STT - #4575
Merged
Merged
Conversation
Co-authored-by: Sylvester Kaczmarek <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes streamed STT WebSocket setup so it derives endpoint routing, query parameters, authentication, default headers, and refreshed callable API keys from the supplied
AsyncOpenAIclient.It centralizes client-derived WebSocket normalization with the Responses WebSocket path while preserving the STT-owned
intent=transcriptionquery parameter andOpenAI-Log-Session: 1header. It also prevents dependency DEBUG logging from exposing WebSocket request paths, header values, or frame contents and retains Python 3.10 compatibility.