Repository navigation
fix(voice) reject ignored explicit-client options - #4527
Merged
seratch merged 2 commits intoAug 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject
organizationandprojectwhenOpenAIVoiceModelProviderreceives an explicitopenai_client.An explicit
AsyncOpenAIclient already owns its organization and project settings. The voice provider currently rejectsapi_keyandbase_urlin this configuration but silently accepts and ignoresorganizationandprojectbecause those values are only stored when the provider constructs its own client.This aligns the voice provider with the same explicit-client contract already used by
OpenAIProvider.Reproduction
On current
main, construction succeeds butorganization="org_other"has no effect. The provider continues using the organization configured onclient.Test plan
Extends the existing explicit-client conflict regression test to cover both
organizationandprojectwhile preserving the valid client-only path.Issue number
N/A